Add display.theme option to control dark/light mode #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
I know the PR requirements ask for tests but I don't see any in this repo. Am I just missing them somewhere? |
|
Thanks for this, specially for docs examples :) There's no test yet |
|
No problem... happy to help! I'll be submitting two bug fixes here shortly too ^_^ |
Eonasdan
added a commit
that referenced
this pull request
Jul 11, 2022
* make viewMode optional (#2551) * introduce a simple overridable function parseInput (#2552) so that you don't have to know all the internal details when overriding this just gets 1 input and can return another Just as formatInput also works (its the opposite) * fixed #2487, #2495 * fixed #2487, #2495 * fix for #2506 * fix for #2549 * fix for #2549 * pub npm * pub npm * package update * * added locale from pr * updated github templates * updated link nav * fixes #2583, #2578 * [IMP] adding support for Arabic locales (#2592) * Add display.theme option to control dark/light mode (#2593) * adding display.theme to control dark vs light mode * removing changes in dist folder per contribution guidelines * fixes #2547 * upstream * fixing bug where side-by-side shows blank clock (#2596) (#2597) * fix clock * fix #2595 * fix #2563 fix #2563 * fix #2599 * fix #2576 * issue templates to forms * fixes #2568 * nuget package * fix spelling and oops * remove commented out code Co-authored-by: Johan Compagner <[email protected]> Co-authored-by: Khaled Said <[email protected]> Co-authored-by: Killian Hale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developmentbranchFeature
This PR adds a display.theme option to control dark/light mode
Current Behavior
The current behavior is to always auto detect and change to dark mode based on the user's system settings
New Behavior
This introduces a new option,
display.themewhich controls the behavior for when to use dark mode instead of light. Setting the theme toauto, which is also the default when no theme is specified, is the current behavior of using dark mode based on the user's system settings.Does this PR introduce a breaking change?
No, the default behavior is as it operates today.
Additional Context
It's awesome to support dark mode but not all consumers of this library may support it (or the opposite) in their styling. This allows them to not have to completely restyle the picker when they don't want to change it in any other way. This is actually the use case I find myself in. I'm on a legacy site that doesn't support dark mode currently and am upgrading from the old date picker which only had light mode.