Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noConflict has no effect ? #2506

Closed
wuding-1104 opened this issue Mar 1, 2022 · 1 comment
Closed

noConflict has no effect ? #2506

wuding-1104 opened this issue Mar 1, 2022 · 1 comment

Comments

@wuding-1104
Copy link

wuding-1104 commented Mar 1, 2022

const name = 'tempusDominus';
$.fn[name] = tempusDominus.jQueryInterface;
$.fn[name].Constructor = tempusDominus.TempusDominus;
const JQUERY_NO_CONFLICT = $.fn[name];
$.fn[name].noConflict = function () {
  $.fn[name] = JQUERY_NO_CONFLICT;
  return tempusDominus.jQueryInterface;
};

As the code in tempus-dominus/src/js/jQuery-provider.js. JQUERY_NO_CONFLICT set after $.fn[name] set to tempusDominus.jQueryInterface, JQUERY_NO_CONFLICT will equals to tempusDominus.jQueryInterface, we lost the raw value of $.fn[name].

Eonasdan added a commit that referenced this issue May 12, 2022
@Eonasdan
Copy link
Owner

Hello, please check the dev branch. I haven't work with jquery in a long time so I've mostly forgotten how it works.

Eonasdan added a commit that referenced this issue May 15, 2022
* make viewMode optional (#2551)

* introduce a simple overridable function parseInput (#2552)

so that you don't have to know all the internal details when overriding
this just gets 1 input and can return another
Just as formatInput also works (its the opposite)

* fixed #2487, #2495

* fixed #2487, #2495

* fix for #2506

* fix for #2549

* fix for #2549

* pub npm

* pub npm

* package update

Co-authored-by: Johan Compagner <[email protected]>
Eonasdan added a commit that referenced this issue Jun 10, 2022
* make viewMode optional (#2551)

* introduce a simple overridable function parseInput (#2552)

so that you don't have to know all the internal details when overriding
this just gets 1 input and can return another
Just as formatInput also works (its the opposite)

* fixed #2487, #2495

* fixed #2487, #2495

* fix for #2506

* fix for #2549

* fix for #2549

* pub npm

* pub npm

* package update

* * added locale from pr
* updated github templates
* updated link nav

* fixes #2583, #2578

Co-authored-by: Johan Compagner <[email protected]>
Eonasdan added a commit that referenced this issue Jul 11, 2022
* make viewMode optional (#2551)

* introduce a simple overridable function parseInput (#2552)

so that you don't have to know all the internal details when overriding
this just gets 1 input and can return another
Just as formatInput also works (its the opposite)

* fixed #2487, #2495

* fixed #2487, #2495

* fix for #2506

* fix for #2549

* fix for #2549

* pub npm

* pub npm

* package update

* * added locale from pr
* updated github templates
* updated link nav

* fixes #2583, #2578

* [IMP] adding support for Arabic locales (#2592)

* Add display.theme option to control dark/light mode (#2593)

* adding display.theme to control dark vs light mode

* removing changes in dist folder per contribution guidelines

* fixes #2547

* upstream

* fixing bug where side-by-side shows blank clock (#2596) (#2597)

* fix clock

* fix #2595

* fix #2563
fix #2563

* fix #2599

* fix #2576

* issue templates to forms

* fixes #2568

* nuget package

* fix spelling and oops

* remove commented out code

Co-authored-by: Johan Compagner <[email protected]>
Co-authored-by: Khaled Said <[email protected]>
Co-authored-by: Killian Hale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants