Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side-by-Side doesn't display calendar #2596

Closed
killianhale opened this issue Jun 28, 2022 · 2 comments
Closed

Side-by-Side doesn't display calendar #2596

killianhale opened this issue Jun 28, 2022 · 2 comments
Labels
Area: TypeScript Priority: Medium Type: Bug

Comments

@killianhale
Copy link
Contributor

Before opening:

Bug reports must include:

  • Operating system and version: macOS Monterey
  • Browser and version: Chrome
  • Version of the plugin. v6-beta8
  • A test and or fork this StackBlitz: I will be opening a PR with the fix that includes adding a side-by-side example to the docs

Issues that do not fork one of the following stackblitz projects will be closed!

I based my upcoming PR on the develop branch so I think I'm covered by the second item on your list
@killianhale killianhale mentioned this issue Jun 28, 2022
Merged
1 task
killianhale added a commit to killianhale/tempus-dominus that referenced this issue Jun 28, 2022
@killianhale
fixing bug where side-by-side shows blank clock (Eonasdan#2596)
c7fdd79
Eonasdan pushed a commit that referenced this issue Jun 28, 2022
@killianhale
fixing bug where side-by-side shows blank clock (#2596) (#2597)
32a8890
@Eonasdan Eonasdan added the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Jun 28, 2022
@Eonasdan
Copy link
Owner

Hello, the development branch was recently updated. Please use this stackblitz to verify your issue is resolved.

Eonasdan added a commit that referenced this issue Jul 11, 2022
@Eonasdan @jcompagner
@kerbrose @killianhale
Beta 9 (#2604)
929a556 
* make viewMode optional (#2551)

* introduce a simple overridable function parseInput (#2552)

so that you don't have to know all the internal details when overriding
this just gets 1 input and can return another
Just as formatInput also works (its the opposite)

* fixed #2487, #2495

* fixed #2487, #2495

* fix for #2506

* fix for #2549

* fix for #2549

* pub npm

* pub npm

* package update

* * added locale from pr
* updated github templates
* updated link nav

* fixes #2583, #2578

* [IMP] adding support for Arabic locales (#2592)

* Add display.theme option to control dark/light mode (#2593)

* adding display.theme to control dark vs light mode

* removing changes in dist folder per contribution guidelines

* fixes #2547

* upstream

* fixing bug where side-by-side shows blank clock (#2596) (#2597)

* fix clock

* fix #2595

* fix #2563
fix #2563

* fix #2599

* fix #2576

* issue templates to forms

* fixes #2568

* nuget package

* fix spelling and oops

* remove commented out code

Co-authored-by: Johan Compagner <[email protected]>
Co-authored-by: Khaled Said <[email protected]>
Co-authored-by: Killian Hale <[email protected]>
@Eonasdan
Copy link
Owner

The dev branch was merged and beta9 was published with a fix.

@Eonasdan Eonasdan removed State: Waiting feedback State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: TypeScript Priority: Medium Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eonasdan @killianhale