Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version2 emergent constraints #1011
Version2 emergent constraints #1011
Changes from 27 commits
f910adc
860faa7
d828489
a1ce99f
461382f
ee21db3
c5b668c
9b405b6
c7c339d
c54f641
da6fbd8
7e05890
851b6b2
d30a6ec
b3d07cb
8ddbe33
974505e
6be9d9e
1509c13
bdc31e5
f782506
58904fa
88b8dca
7a1fad1
a8c4a84
7f0aa8c
847b7d0
0a2217a
465ab15
548c667
cc423da
9b28e1a
996c14d
bfd782a
c5596f7
dee8a61
00ffca1
7704c45
e1d56c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use yaml configuration files instead of cdl/netcdf, maybe this can simply go in the recipe? It seems to depend on the models you are using anyway, so would need changing if the model set changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not something that should to into a recipe as these numbers are either the result of another diagnostic or taken from literature (user choice). NetCDF is easy to process with NCL whereas yaml is not. The cdl script is provided so that an advanced user can add data easily if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this may be the easy solution for you as a programmer, I think it is not easy for users.