-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version2 emergent constraints #1011
Version2 emergent constraints #1011
Conversation
…p/ESMValTool into version2_emergent_constraints
PR #1012 seems to fix the problems the CircleCI complaints about the CMIP6 fixes. |
Yes, it was the missing
in your branch should fix it 👍 |
Changed figure labels to avoid duplicate labels. Thanks for pointing out this problem. Not sure what you mean by scrambled documentation, though. |
@axel-lauer the time operations of the preprocessor have recently been refactored and renamed in ESMValGroup/ESMValCore#87 . Unfortunately this means you have to revise the time preprocessing you do in your recipe and/or diagnostic. For more information see the new set of time operations (old functionality still available but named differently and generalized). |
@JaroCamphuijsen not sure what you mean as no time operations are done by the preprocessor in the recipe added in this PR. Just merged the latest version2_development into this branch and tested the new recipe. Works fine. |
@JaroCamphuijsen I think it is better to sort by actual headline that will show up in the user's guide than by file name appearing nowhere but in index.rst: emergent_constraints: Emergent constraints for equilibrium climate sensitivity So I will not change the current position of "recipe_emergent_constraints" in index.rst. |
I agree with you that the current way is not necessarily the best way, but I think this is currently how this file is sorted, so we should stick with it. If you want to suggest to do it your way maybe you can start an issue where we can discuss this and then we can apply it to all recipes in index.rst That said, maybe letting the merge depend on this discussion is not worth it, the rest look fine to me. @mattiarighi could you review this so it can be merged? |
@JaroCamphuijsen the convention how files are sorted in index.rst was and is in alphabetical order sorted by headline, not by filename. That is because we do not have any conventions for naming the files, so authors are free to use e.g. acronyms to name their .rst file. As the of the user's guide reader cannot see the file names but only the actual headlines, we sort by headline. This is not up for discussion as the user's guide will become a mess otherwise. We can, however, discuss introducing a naming scheme for the individual .rst files, but I currently do not see a pressing need for that. |
There is an issue with a custom variable (
I'm afraid this is due to the recent update to the cmor tables in core. |
Ok. Problem found
obs4mips:
cmor_strict: true
input_dir:
default: 'Tier{tier}/{dataset}'
RCAST: '/'
input_file: '{short_name}_{dataset}_{level}_{version}_*.nc'
input_fx_dir:
default: 'Tier{tier}/{dataset}'
input_fx_file:
default: '{project}_{dataset}_fx_{fx_var}.nc'
output_file: '{project}_{dataset}_{level}_{version}_{short_name}_{start_year}-{end_year}'
cmor_type: 'CMIP6'
cmor_path: 'obs4mips'
cmor_default_table_prefix: 'obs4MIPs_' If we can have obs4mips-like variables that are not part of its tables, we should revert the change and set |
…p/ESMValTool into version2_emergent_constraints
@jvegasbsc Please revert the change for obs4mips from "cmor_strict: true" back to "cmor_strict: false" in config-developer.yml. As the obs4mips tables do not contain (their own) error variables, we had to add custom cmor tables for those variables. Being able to process error variables from obs4mips (and other observational products!) is absolutely essential for any advanced model evaluation. |
This PR adds the following emergent constraints for equilibrium climate sensitivity (ECS):
The new recipes (recipe_ecs_scatter.yml and recipe_ecs_scatter_cmip6.yml) have been tested with CMIP5 and CMIP6 data. The code works fine but CirecleCI reports the following error for the newly added CMIP6 fix files:
collection failure
esmvaltool/cmor/_fixes/CMIP6/BCC_CSM2_MR.py:6: in
from ..fix import Fix
E ImportError: attempted relative import with no known parent package
The files in question are:
The reason for the complaints by CircleCI are not clear to me. Advice welcome!