Add kessler_test Test SDF for FPHYStest to split off from FKESSLER test #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st (which includes physics_after_coupler)
mattldawson
pushed a commit
that referenced
this pull request
Feb 20, 2025
…st (#204) Originator(s): jimmielin Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): The FPHYStest test for Kessler in SIMA right now uses the same `suite_kessler.xml` as FKESSLER, which means it includes `physics_after_coupler` and other `check_energy` schemes we do not want to include in the FPHYStest test which should only be testing `kessler_tend`. This PR includes a new `suite_kessler_test.xml` that removes all the other schemes from the SDF and keeps only what we want to test, and consistent with how the snapshots are taken in CAM: ```fortran if (trim(cam_take_snapshot_before) == "kessler_tend") then call cam_snapshot_all_outfld(cam_snapshot_before_num, state, tend, cam_in, cam_out, pbuf) end if call kessler_tend(state, ptend, ztodt, pbuf) if ( (trim(cam_take_snapshot_after) == "kessler_tend") .and. & (trim(cam_take_snapshot_before) == trim(cam_take_snapshot_after))) then call cam_snapshot_ptend_outfld(ptend, lchnk) end if call physics_update(state, ptend, ztodt, tend) if (trim(cam_take_snapshot_after) == "kessler_tend") then call cam_snapshot_all_outfld(cam_snapshot_after_num, state, tend, cam_in, cam_out, pbuf) end if ``` List all namelist files that were added or changed: N/A List all files eliminated and why: N/A List all files added and what they do: ``` A test/test_suites/suite_kessler_test.xml - new kessler_test suite ``` List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) N/A List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? Yes for FPHYStest kessler test If yes to the above question, describe how this code was validated with the new/modified features: BFB when using this suite
mwaxmonsky
added a commit
that referenced
this pull request
Feb 21, 2025
Tag name (The PR title should also include the tag name): atmos_phys0_09_000 Originator(s): @mwaxmonsky List all `development` PR numbers included in this PR and the title of each: * Add diagnostic output for ALL constituents #199 by @peverwhee * Build MUSICA in CAM-SIMA #198 by @boulderdaze * Implement thermo_water_update scheme (non-portable wrapper to cam_thermo_water_update) #178 by @jimmielin and @nusbaume * Implement diagnostics for global energy fixer, check_energy standard name update #169 by @jimmielin * Add kessler_test Test SDF for FPHYStest to split off from FKESSLER test #204 by @jimmielin * PBL utils transfer #193 by @mwaxmonsky and @nusbaume List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): jimmielin
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
The FPHYStest test for Kessler in SIMA right now uses the same
suite_kessler.xmlas FKESSLER, which means it includesphysics_after_couplerand othercheck_energyschemes we do not want to include in the FPHYStest test which should only be testingkessler_tend.This PR includes a new
suite_kessler_test.xmlthat removes all the other schemes from the SDF and keeps only what we want to test, and consistent with how the snapshots are taken in CAM:List all namelist files that were added or changed: N/A
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)N/A
List all automated tests that failed, as well as an explanation for why they weren't fixed:
N/A
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
Yes for FPHYStest kessler test
If yes to the above question, describe how this code was validated with the new/modified features:
BFB when using this suite