Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic output for ALL constituents #199

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

peverwhee
Copy link
Collaborator

Originator(s): peverwhee

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
The sima_state_diagnostics scheme only output the "known" constituents. This PR adds history add and out field calls for ALL other constituents. I'm open to discussion about the diagnostic names for these!

Describe any changes made to the namelist: n/a

List all files eliminated and why: n/a

List all files added and what they do: n/a

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M schemes/sima_diagnostics/sima_state_diagnostics.F90

  • add "history_add_field" and "history_out_field" calls for constituents outside of the core expected ones.

List any test failures: all CAM-SIMA tests pass

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? no - diagnostics update

@peverwhee peverwhee self-assigned this Feb 1, 2025
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just wanted to add a note here that we should generalize this code (and remove the automatic use of the standard name as the diagnostic name) once NCAR/ccpp-framework#635 has been implemented and merged.

@peverwhee peverwhee requested a review from cacraigucar February 4, 2025 17:26
@peverwhee peverwhee merged commit 0e417de into ESCOMP:development Feb 4, 2025
3 checks passed
mattldawson pushed a commit that referenced this pull request Feb 11, 2025
Originator(s): peverwhee

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):
The sima_state_diagnostics scheme only output the "known" constituents.
This PR adds history add and out field calls for ALL other constituents.
I'm open to discussion about the diagnostic names for these!

Describe any changes made to the namelist: n/a

List all files eliminated and why: n/a

List all files added and what they do: n/a

List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
M   schemes/sima_diagnostics/sima_state_diagnostics.F90
- add "history_add_field" and "history_out_field" calls for constituents
outside of the core expected ones.

List any test failures: all CAM-SIMA tests pass

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? no - diagnostics update
mwaxmonsky added a commit that referenced this pull request Feb 21, 2025
Tag name (The PR title should also include the tag name):
atmos_phys0_09_000
Originator(s): @mwaxmonsky 

List all `development` PR numbers included in this PR and the title of
each:
* Add diagnostic output for ALL constituents #199 by @peverwhee
* Build MUSICA in CAM-SIMA #198 by @boulderdaze
* Implement thermo_water_update scheme (non-portable wrapper to cam_thermo_water_update) #178 by @jimmielin and @nusbaume
* Implement diagnostics for global energy fixer, check_energy standard name update #169 by @jimmielin
* Add kessler_test Test SDF for FPHYStest to split off from FKESSLER test #204 by @jimmielin
* PBL utils transfer #193 by @mwaxmonsky and @nusbaume

List all automated tests that failed, as well as an explanation for why
they weren't fixed: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants