Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New develop merger #645

Merged
merged 4 commits into from
Jul 19, 2024
Merged

New develop merger #645

merged 4 commits into from
Jul 19, 2024

Conversation

al-rigazzi
Copy link
Collaborator

The commits were not correctly kept in the previous merger.

ankona and others added 4 commits July 17, 2024 17:42
…Labs#638)

Adds the ability to specify hardware affinities for cpu/gpu devices.
Creates a dragon policy that uses provided policy to modify the
resulting dragon ProcessGroup.

[ committed by @ankona ]
[ approved by @AlyssaCote @mellis13 @al-rigazzi ]
setup.py used to define dependencies in a way that was not amenable to
code scanning tools. Direct dependencies now appear directly in the
setup call and the definition of the SmartRedis version has been
removed. Additionally, the code scanning tool was failing to detect some
of the dependencies due to the existence of the requirements-doc.txt
file. These requirements are now listed in the `docs` extra.

[ committed by @ashao ]
[ reviewed by @ankona ]
This PR addresses an inconstent internal host name representation in the
Dragon backend.

[ committed by @al-rigazzi ]
[ reviewed by @ankona ]
@al-rigazzi al-rigazzi requested review from AlyssaCote and ankona July 18, 2024 22:58
@al-rigazzi al-rigazzi mentioned this pull request Jul 18, 2024
Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending everything passes, LGTM!

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@7169f1c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #645   +/-   ##
==============================================
  Coverage               ?   66.34%           
==============================================
  Files                  ?       97           
  Lines                  ?     6760           
  Branches               ?        0           
==============================================
  Hits                   ?     4485           
  Misses                 ?     2275           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/launcher/dragon/dragonBackend.py 2.14% <0.00%> (ø)

@al-rigazzi al-rigazzi merged commit 84101b3 into CrayLabs:mli-feature Jul 19, 2024
44 checks passed
@al-rigazzi al-rigazzi deleted the new-merger branch July 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants