Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop merger #644

Closed

Conversation

al-rigazzi
Copy link
Collaborator

Merging current state of develop into MLI feature branch.

@al-rigazzi al-rigazzi requested review from AlyssaCote and ankona July 18, 2024 22:44
Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@al-rigazzi al-rigazzi closed this Jul 18, 2024
@al-rigazzi
Copy link
Collaborator Author

Sorry @AlyssaCote had to close this PR because the commits were not correctly kept. Can you take a look at #645 ?

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@7169f1c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #644   +/-   ##
==============================================
  Coverage               ?   50.86%           
==============================================
  Files                  ?       89           
  Lines                  ?     6677           
  Branches               ?        0           
==============================================
  Hits                   ?     3396           
  Misses                 ?     3281           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants