-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More easily discoverable dependencies #635
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #635 +/- ##
===========================================
- Coverage 69.68% 63.38% -6.30%
===========================================
Files 83 83
Lines 6208 6208
===========================================
- Hits 4326 3935 -391
- Misses 1882 2273 +391 |
setup.py
Outdated
"pyzmq>=25.1.2", | ||
"pygithub>=2.3.0", | ||
"numpy<2", | ||
"smartredis>=0.5,<0.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation nitpick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
setup.py used to define dependencies in a way that was not amenable to code scanning tools. Direct dependencies now appear directly in the setup call and the definition of the SmartRedis version has been removed. Additionally, the code scanning tool was failing to detect some of the dependencies due to the existence of the requirements-doc.txt file. These requirements are now listed in the
docs
extra.