Changed to netstandard2.0 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flytzen
commented
May 3, 2022
| @@ -1,7 +1,7 @@ | |||
| | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netstandard2.0;net45;net5.0;net6.0</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;net462</TargetFrameworks> | |||
There was a problem hiding this comment.
Oddly, if I set it to only netstandard2.0, the Web sample project stops working correctly: It gets confused about a lot of other references and stops copying the QRCcoder.dll. I think it's partly because net462 includes the QRCoder.dll in the output, whereas netstandard2.0 just includes a ..deps.json.
When I include net462 here, the web project works correctly. In any case, there is little harm in including net462 as well.
|
@ahwm When happy, please "Squash and merge" rather than just "Merge" :) |
ahwm
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
Fixes #105