Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change supported framework versions #107

Closed
3 tasks done
flytzen opened this issue May 2, 2022 · 2 comments · Fixed by #114
Closed
3 tasks done

Change supported framework versions #107

flytzen opened this issue May 2, 2022 · 2 comments · Fixed by #114
Assignees

Comments

@flytzen
Copy link
Collaborator

flytzen commented May 2, 2022

Change supported framework versions to align with what is now supported. Maybe move to netstandard 2.0 to keep it simple.

See #106 for discussions about framework versions

  • The Unit Test project should explicitly support a wide range of specific versions to ensure we test that it actually works.
  • Remove the #if and the declaration of framework specific constants from the main package
  • Test the two sample projects still work
@flytzen
Copy link
Collaborator Author

flytzen commented May 2, 2022

@ahwm Shall we try to just target netstandard2.0 in the main package but have the unit tests target 4.6.2 and various others? We can always add explicit support for other frameworks in the main package if any of the tests fail.

@ahwm
Copy link
Collaborator

ahwm commented May 2, 2022

@ahwm Shall we try to just target netstandard2.0 in the main package but have the unit tests target 4.6.2 and various others? We can always add explicit support for other frameworks in the main package if any of the tests fail.

That works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants