Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if Libgdplus still required #109

Closed
flytzen opened this issue May 2, 2022 · 2 comments · Fixed by #115
Closed

Test if Libgdplus still required #109

flytzen opened this issue May 2, 2022 · 2 comments · Fixed by #115

Comments

@flytzen
Copy link
Collaborator

flytzen commented May 2, 2022 •
edited
Loading

When #105 is implemented, test if Libgdplus requirement is obsolete and update docs as required.

Remove some or all of the following code if success:

            catch (System.Runtime.InteropServices.ExternalException e)
            {
                if (e.Message.Contains("GDI+") && qrPixelsPerModule > 10)
                {
@flytzen
Copy link
Collaborator Author

flytzen commented May 3, 2022

@ahwm Once #114 is merged, do you mind if I push 3.0.0-beta1 to Nuget? It will make it much easier to test Libgdplus.

@ahwm
Copy link
Collaborator

ahwm commented May 5, 2022

@flytzen go right ahead.

@flytzen flytzen mentioned this issue May 6, 2022
Merged
@ahwm ahwm closed this as completed in #115 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed handling of missing libgdiplus BrandonPotter/GoogleAuthenticator
2 participants
@flytzen @ahwm