Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure property name is only last word, not including type name #92

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #91

Fixes a bug where the Property name upgrades got assigned the name of the class, including namespace + the new property name. Now changed to only pick out the last value.

Test files

Can be tested with BHoM/BHoM#961

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Aug 14, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.3 β MVP milestone Aug 14, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Aug 14, 2020
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh
Copy link
Contributor Author

/azp run Versioning_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the functionality, works fine - happy to approve 👍

@IsakNaslundBh IsakNaslundBh merged commit 0441ba4 into master Aug 14, 2020
@IsakNaslundBh IsakNaslundBh deleted the Versioning_Toolkit-#91-FixPropertyNameUpgrades branch August 14, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning_Toolkit: Property renaming does not give the correct value to the new Property
3 participants