Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property name upgrade requires a full namespace check #86

Closed
rolyhudson opened this issue Jul 22, 2020 · 1 comment
Closed

Property name upgrade requires a full namespace check #86

rolyhudson opened this issue Jul 22, 2020 · 1 comment
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@rolyhudson
Copy link
Contributor

rolyhudson commented Jul 22, 2020

Description:

If I want to add a Property name change to versioning like this:

"ToNew": {
      "BH.oM.Audience.ProfileParameters.NumRows" : "BH.oM.Audience.ProfileParameters.Rows"
    },

NumRows is replaced with the full namespace and new property name BH.oM.Audience.ProfileParameters.Rows

Annotation 2020-07-22 114013

Steps to reproduce:

This branch includes a single simple property name change:
NumRows to Rows on the ProfileParameters object
The branch includes the Versioning_33.json

Expected behaviour:

Only the new property name is added to the new version.
In this case NumRows is replaced with Rows

Test file(s):

This file contains a json string of the object with the old property name (as in the image above)

@adecler
Copy link
Member

adecler commented Nov 11, 2020

Fixed by #92

@adecler adecler closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants