Structure_oM: Renaming master/slave to primary/secondary #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run BHoM.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks great. Before pushing it any more though, would be good to get #959 closed out, as both of these PRs will affect Versioning. |
|
/azp run BHoM.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Aug 12, 2020
|
/azp run BHoM.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
IsakNaslundBh
changed the title
IsakNaslundBh
previously approved these changes
Aug 14, 2020
There was a problem hiding this comment.
All look good to me!
Requires BHoM/Versioning_Toolkit#92 to correctly version, but all fine here!
added 6 commits
August 14, 2020 17:17
THOW OFF THE CHAINS OF OPPRESSION!
This reverts commit 1154634.
IsakNaslundBh
force-pushed
the
Structure_oM-#921-rename-RigidLink-nodes
branch
from
564a058 to
a8e4694
Compare
|
/azp run BHoM.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
al-fisher
approved these changes
Aug 14, 2020
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THOW OFF THE CHAINS OF OPPRESSION!
NOTE: Depends on
Issues addressed by this PR
Closes #921
renamed master/slave to primary/secondary
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/BHoM/Structure_oM/Issue921-RigidLink%20property%20rename/Test%20Rigid%20Links%20-%20multi%20adapter.gh?csf=1&web=1&e=iDXtGs
Changelog
Additional comments