Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed RigidLink master/slave to primary/secondary #140

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Aug 12, 2020

@JosefTaylor
Copy link
Contributor Author

/azp run BHoM.CheckInstaller

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JosefTaylor JosefTaylor changed the title replace master/slave with primary/secondary Renamed RigidLink master/slave to primary/secondary Aug 13, 2020
@JosefTaylor JosefTaylor added type:compliance Non-conforming to code guidelines type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Aug 13, 2020
@JosefTaylor
Copy link
Contributor Author

/azp run SAP2000_Toolkit.CheckCore

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JosefTaylor
Copy link
Contributor Author

/azp run SAP2000_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@maryannewachter maryannewachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested against all 3 test files in Structure_oM.

@al-fisher al-fisher merged commit 0641c56 into master Aug 14, 2020
@al-fisher al-fisher deleted the Structure_oM-#921-rename-RigidLink-nodes branch August 14, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants