Fix crash on invalid mesh preview in Rhino #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epignatelli
approved these changes
May 14, 2020
There was a problem hiding this comment.
Thanks @adecler !
I also found a small bug in Grasshopper when rendering Mesh wires.
Meshes are rendered even if there are no vertices, I'll raise a pr there as well.
|
Actually, no, I take that back. We never perform checks in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #160
Faces are added to the Rhino mesh if the vertices exist (well, the index exists). Faces not added will trigger a warning:
Test files
See issue for test file
Additional comments
@epignatelli , I am on your turf here so I hope I don't collide with your current plans (doesn't look like I do given sprint minutes). If I do, feel free to put this on hold. Also happy for you to use a different strategy to solve the issue if you feel this is creating side effects on the normal use of this toolkit.