Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhinoceros_Toolkit: Preview of invalid mesh crashes Rhino #160

Closed
pawelbaran opened this issue May 8, 2020 · 1 comment · Fixed by #161
Closed

Rhinoceros_Toolkit: Preview of invalid mesh crashes Rhino #160

pawelbaran opened this issue May 8, 2020 · 1 comment · Fixed by #161
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

Description:

When the face is clicked in first, Rhino crashes:
RevitAdapter

My gut feeling is that this is a preview issue, but please do not get suggested 🙊

Test file(s):

On SharePoint.

@adecler
Copy link
Member

adecler commented May 14, 2020

It is indeed a preview issue. The code crashes at this line when in the output parameter for teh mesh:

image

The problem is that a try-catch doesn't prevent the crash as it happens in Rhino and not Grasshopper.

So this needs to be fixed in Rhinoceros_Toolkit by making sure a face is created only when it can find the corresponding vertices.

I'll transfer this issue to Rhinoceros_Toolkit and will PR a solution soon.

@adecler adecler transferred this issue from BHoM/Grasshopper_UI May 14, 2020
@adecler adecler added the type:bug Error or unexpected behaviour label May 14, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 14, 2020
@adecler adecler changed the title Grasshopper_Toolkit: mesh autoconstructor bug crashes Rhino Rhinoceros_Toolkit: mesh autoconstructor bug crashes Rhino May 14, 2020
@adecler adecler changed the title Rhinoceros_Toolkit: mesh autoconstructor bug crashes Rhino Rhinoceros_Toolkit: Preview of invalid mesh crashes Rhino May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants