Fix crash on invalid mesh preview in Rhino

BHoM · May 14, 2020 · b235044 · b235044
1 parent 2b7da0c
commit b235044
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/Rhinoceros_Engine/Convert/ToRhino.cs b/Rhinoceros_Engine/Convert/ToRhino.cs
@@ -453,15 +453,24 @@ public static RHG.Mesh ToRhino(this BHG.Mesh mesh)
             List<RHG.Point3d> rVertices = mesh.Vertices.Select(x => x.ToRhino()).ToList();
             List<BHG.Face> faces = mesh.Faces;
             List<RHG.MeshFace> rFaces = new List<RHG.MeshFace>();
+            int nbVertices = rVertices.Count;
             for (int i = 0; i < faces.Count; i++)
             {
-                if (faces[i].IsQuad())
+                BHG.Face face = faces[i];
+                if (face.IsQuad())
                 {
-                    rFaces.Add(new RHG.MeshFace(faces[i].A, faces[i].B, faces[i].C, faces[i].D));
+
+                    if (face.A < nbVertices && face.B < nbVertices && face.C < nbVertices && face.D < nbVertices)
+                        rFaces.Add(new RHG.MeshFace(face.A, face.B, face.C, face.D));
+                    else
+                        Reflection.Compute.RecordWarning("Mesh face [" + face.A + ", " + face.B + ", " + face.C + ", " + face.D + "] could not be created due to corresponding vertices missing");
                 }
                 else
                 {
-                    rFaces.Add(new RHG.MeshFace(faces[i].A, faces[i].B, faces[i].C));
+                    if (face.A < nbVertices && face.B < nbVertices && face.C < nbVertices)
+                        rFaces.Add(new RHG.MeshFace(face.A, face.B, face.C));
+                    else
+                        Reflection.Compute.RecordWarning("Mesh face [" + face.A + ", " + face.B + ", " + face.C + "] could not be created due to corresponding vertices missing");
                 }
             }
             RHG.Mesh rMesh = new RHG.Mesh();