Align with auto-versioning during serialisation #263
Conversation
adecler
requested review from
alelom,
al-fisher,
FraserGreenroyd,
IsakNaslundBh and
epignatelli
|
Now that there is no dependency left, I have remove the reference to Mongo Bson |
adecler
force-pushed
the
BHoM_UI-#262-AlignWithAutoVersioning
branch
from
2d1b23a to
12d5099
Compare
There was a problem hiding this comment.
All seem to be runnign fine, see:
BHoM/BHoM_Engine#1762 (review)
Only thing is no message is shown any longer for older scripts being upgraded with a big risk of loosing their wires. But will leave it to you @adecler and @al-fisher to say if that is a big issue or not.
There was a problem hiding this comment.
Approving in line with this review as this was tested together.
Unfortunately that was the price to pay for having the auto-versioning happening during deserialisation. The UI is not aware that versioning happened anymore so doesn't know when to trigger the warning. Thankfully, this is only for the older scripts that didn't save the inputs/outputs. |
|
/azp run BHoM_UI.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NOTE: Depends on
BHoM/BHoM_Engine#1762
(at least on a behavioural level so recommend to review them together)
Issues addressed by this PR
Closes #262
Without this, you will have missing wires when testing BHoM/BHoM_Engine#1762
Test files
Old files that contain components that need upgrading