Fix detection of upgraded SelectedItem for Types #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
requested review from
al-fisher,
FraserGreenroyd,
IsakNaslundBh and
kThorsager
kThorsager
approved these changes
Jun 12, 2020
IsakNaslundBh
approved these changes
Jun 12, 2020
FraserGreenroyd
approved these changes
Jun 12, 2020
|
/azp run BHoM_UI.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #278
PR #263 broke the ability for the
CreateObjectcomponent to add and remove inputs. The reason is that we lost the ability to easily know if theSelectedItemwas upgraded by the Versioning engine since it is now black-boxed inside theFromJsonmethod. So, in that PR, I tried to detect an upgrade by comparing the inputs and outputs. The problem is that I forgot the case ofCreateObjectwhere inputs can be modified by the user.I have now overridden in
CrerateObjectthe check done inCaller. If theSelectedItemis a type, I just make sure that all the component inputs can still be found as property of the object.This component is getting messy and too fragile for my liking so I will review it properly next quarter with the general review of the UI. But this PR focuses on fixing the problematic bug before the release of the beta installer.
Test files
See issue