-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Auto-versioning of methods and types during serialisation #1762
Serialiser_Engine: Auto-versioning of methods and types during serialisation #1762
Conversation
Now also takes care of issue #1766 . |
I strongly recommend reviewing and merging this alongside BHoM/BHoM_UI#263 as that fixes the missing wires on upgrades. |
ba8ed19
to
c7477f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested this together with BHoM/BHoM_UI#263 and it all seem to be running fine for me.
I have started to collect various version tests from different UIs and BHoM versions on sharepoint here: https://burohappold.sharepoint.com/:f:/s/BHoM/EopxQb5d9QdDqKoD--1178kBUpVHnKPZ1WWwyI2Eg1l18Q?e=hDsyDU
Good place to put more scripts for testing the versioning if/when it changes.
Tested through the GH scripts and most dynamo scripts, and all seem to be running with a few exceptions, that are somewhat expected.
Would be good though if one more person would be able to have a look at this before merging.
@peterjamesnugent can you test that your adapter versioning is working well for you.
@kThorsager I have probably tested through most of your stuff already, but always good to get a second pair of eyes.
@FraserGreenroyd if you have anything from BEnv that has been versioned, would you mind running those scripts as well.
Then all, if you have any script that has seen versioning, would you mind putting them in the linked sharepoint folder under the correct version, for ease of testing going forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a couple of my scripts and all seemed to upgrade ok as I would have expected, though I don't have an abundance of versioning testing scripts.
/azp run BHoM_Engine.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
Issues addressed by this PR
Closes #1738
Closes #1766
Methods and types are now upgraded directly during deserialisation, not need to call ToNewVersion separately.
Test files
Here's what I have tested on. But I recommend to use the usual serialisation test files on SharePoint:
Here's the json used in there (in order of complexity, raw type, Custom object containing the type as property, List of that type to cover generic types, method that needs that type to be updated for it to work ):
I strongly recommend reviewing and merging this alongside BHoM/BHoM_UI#263 as that fixes the missing wires on upgrades.