-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Fix remaining problems with serialisation #1756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IsakNaslundBh , it works perfectly fine for me so we probably need to do a screen share on this one: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After chat with arnaud, ready to approve as this generally makes things better (the tapered profiles does no de-serialise correctly on my machine on master either).
I have raised the following issues to get this fixed:
BHoM/BHoM#860
#1760
Approving on the basis that the rest is working as expected
/azp run BHoM_Engine.CheckInstaller |
/azp run BHoM_Engine.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
NOTE: Depends on
BHoM/BHoM#857
BHoM/Test_Toolkit#247
Issues addressed by this PR
Closes #1620
Closes #1755
Closes #1737
Yatta !! Finally got all types working (at least those on my computer).
This fixes the serialiser itself but will be accompanied by a few corrections on the non-compliant types themselves to get it all working (see PRs in the
depends on
section)Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/BHoM_Engine/Serializer_Engine/serialisationTest.gh?csf=1&web=1&e=1okDsJ
If you have types failing on your machine, please make sure they compliant first. A common issue for example is an incorrect constructor for
IImmutable
classes.Changelog
Additional comments
FYI, A dummy object cannot be created for
MaterialComposition
because it has a restriction inside its constructor that throws an exception if that constraint is not met.