Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground_Engine: Remove blankGeology from Stratum Create method #3375

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jul 11, 2024

Issues addressed by this PR

Closes #3374

Test files

#12-HandlingBlankGeology.gh - this requires BHoM/AGS_Toolkit#13 to be built
#3374-VersionCheckForStratum this requires the Versioning_Toolkit to be built

Changelog

  • Removed blankGeology from the Create method for Stratum and versioned the method;

Additional comments

Do not merge until the AGS_Toolkit PR is ready

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 11, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

@Martian42 Martian42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested along with AGS_toolkit PR. Work as intended.

@pawelbaran
Copy link
Member

@BHoMBot check documentation-compliance

Copy link

bhombot-ci bot commented Jul 11, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check documentation-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 11, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent peterjamesnugent added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jul 11, 2024
Copy link

bhombot-ci bot commented Jul 12, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27334488723

1 similar comment
Copy link

bhombot-ci bot commented Jul 12, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27334488723

@pawelbaran
Copy link
Member

Dispensating UTs on the basis of them being broken in the previous PRs.

@pawelbaran
Copy link
Member

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27334488723

Copy link

bhombot-ci bot commented Jul 12, 2024

@pawelbaran I have now provided a passing check on reference 27334488723 as requested.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 12, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jul 12, 2024
@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 12, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 13 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 3daebf9 into develop Jul 12, 2024
12 checks passed
@pawelbaran pawelbaran deleted the Ground_Engine-#3374-RemoveBlankGeologyInputFromCreateMethod branch July 12, 2024 12:38
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground_Engine: Remove blankGeology input from Create method for Stratum
3 participants