-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground_Engine: Remove blankGeology from Stratum Create method #3375
Ground_Engine: Remove blankGeology from Stratum Create method #3375
Conversation
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested along with AGS_toolkit PR. Work as intended.
@BHoMBot check documentation-compliance |
@pawelbaran to confirm, the following actions are now queued:
|
@peterjamesnugent to confirm, the following actions are now queued:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
1 similar comment
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
Dispensating UTs on the basis of them being broken in the previous PRs. |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 27334488723 |
@pawelbaran I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #3374
Test files
#12-HandlingBlankGeology.gh - this requires BHoM/AGS_Toolkit#13 to be built
#3374-VersionCheckForStratum this requires the Versioning_Toolkit to be built
Changelog
blankGeology
from theCreate
method forStratum
and versioned the method;Additional comments
Do not merge until the AGS_Toolkit PR is ready