Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different methods for handling blank GEOL_GEOL #13

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jun 28, 2024

NOTE: Depends on

BHoM/BHoM_Engine#3375

Issues addressed by this PR

Closes #12

Test files

https://burohappold.sharepoint.com/:x:/s/BHoM/EYiWcAMZ_jFAl782pP6Pgv8BAGorGhyPFzg3r_3PD6p_ew?e=K8CPRI

Changelog

  • Added BlankGeologyStrategy that lets the user select different methods for handling empty GEOL_GEOL fields;
  • The Replace will replace the blank field with a specific string;
  • The Lexicon will replace the blank field with the lexicon code (if not empty);
  • The Legend will replace the blank field with the legend code (if not empty);
  • The Description will replace the blank field with the capitalised words in the description;

Additional comments

This will need to wait for the BHoM_Engine PR to be merged first as the branches are different names.

@peterjamesnugent peterjamesnugent changed the title Add difference methods for handling blank GEOL_GEOL Add different methods for handling blank GEOL_GEOL Jul 11, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Jul 11, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check project-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 11, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check project-compliance
  • check copyright-compliance

@peterjamesnugent peterjamesnugent added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jul 11, 2024
Copy link
Contributor

@Martian42 Martian42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality with test script using an .ags file with empty GEOL. All option works as intented.

@peterjamesnugent peterjamesnugent removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jul 12, 2024
@peterjamesnugent peterjamesnugent merged commit 017d7e6 into develop Jul 12, 2024
2 checks passed
@peterjamesnugent peterjamesnugent deleted the AGS_Toolkit-#12-AddDifferentMethodsForHandlingBlankGeology branch July 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read GEOL_GEOL code from description
2 participants