generated from BHoM/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add different methods for handling blank GEOL_GEOL #13
Merged
peterjamesnugent
merged 5 commits into
develop
from
AGS_Toolkit-#12-AddDifferentMethodsForHandlingBlankGeology
Jul 12, 2024
Merged
Add different methods for handling blank GEOL_GEOL #13
peterjamesnugent
merged 5 commits into
develop
from
AGS_Toolkit-#12-AddDifferentMethodsForHandlingBlankGeology
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…different methods for replacing blank geology
@peterjamesnugent to confirm, the following actions are now queued:
|
@peterjamesnugent to confirm, the following actions are now queued:
|
Martian42
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionality with test script using an .ags file with empty GEOL. All option works as intented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Engine#3375
Issues addressed by this PR
Closes #12
Test files
https://burohappold.sharepoint.com/:x:/s/BHoM/EYiWcAMZ_jFAl782pP6Pgv8BAGorGhyPFzg3r_3PD6p_ew?e=K8CPRI
Changelog
BlankGeologyStrategy
that lets the user select different methods for handling empty GEOL_GEOL fields;Replace
will replace the blank field with a specific string;Lexicon
will replace the blank field with the lexicon code (if not empty);Legend
will replace the blank field with the legend code (if not empty);Description
will replace the blank field with the capitalised words in the description;Additional comments
This will need to wait for the BHoM_Engine PR to be merged first as the branches are different names.