Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground_Engine: Remove blankGeology from Stratum Create method #3375

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Ground_Engine: Remove blankGeology from Stratum Create method #3375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions Ground_Engine/Create/Stratum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
/**** Public Methods ****/
/***************************************************/

[PreviousVersion("7.3", "BH.Engine.Ground.Create.Stratum(System.String, System.Double, System.Double, System.String, System.String, System.String, System.String, System.String, System.String, System.Collections.Generic.List<BH.oM.Ground.IStratumProperty>)")]
[Description("Creates a Stratum element based on its strata, descriptions and optional geological properties. The lists must be of equal length.")]
[Input("id", "Location identifier for the borehole unique to the project (LOCA_ID).")]
[Input("top", "Depth to the top of the strata based on the datum provided on the Borehole (GEOL_TOP).")]
Expand All @@ -48,11 +49,11 @@
[Input("observedGeology", "Observed geologies expressed as a GeologicalUnit (GEOL_GEOL).")]
[Input("interpretedGeology", "Interpreted geologies expressed as an EngineeringMaterial (GEOL_GEO2).")]
[Input("optionalInterpretedGeology", "The optional interpreted geology expressed as an EngineeringMaterial(GEOL_GEO3).")]
[Input("blankGeology", "The geology to use where blank spaces occur in the observedGeology parameter.")]
[Input("properties", "A list of properties related to the borehole.")]
[Output("stratum", "Stratum object containing information for each strata including descriptions, legend codes and optional geological properties.")]

public static Stratum Stratum(string id, double top, double bottom, string logDescription, string legend,

Check failure on line 55 in Ground_Engine/Create/Stratum.cs

View check run for this annotation

BHoMBot-CI / documentation-compliance

Ground_Engine/Create/Stratum.cs#L55 

Methods implementing a PreviousVersion versioning attribute should implement it for the current version of development. Methods with PreviousVersion attributes from previous milestones should have those attributes removed - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/HasValidPreviousVersionAttribute
string observedGeology, string interpretedGeology = "", string optionalInterpretedGeology = "", string blankGeology = "", List<IStratumProperty> properties = null)
string observedGeology, string interpretedGeology = "", string optionalInterpretedGeology = "", List<IStratumProperty> properties = null)
{
if(id == "")
{
Expand All @@ -66,12 +67,6 @@
return null;
}

if (!blankGeology.Trim().IsNullOrEmpty())
{
if (observedGeology.Trim().IsNullOrEmpty())
observedGeology = blankGeology;
}

return new Stratum()
{
Id = id,
Expand Down
Loading