-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning with Grid and Level migration to Spatial #2732
Aligning with Grid and Level migration to Spatial #2732
Conversation
@BHoMBot check installer Using the Bot to identify the toolkits affected by this change. I do not expect this check to pass. |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
Required to handle older versioning files
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following checks are now queued:
|
@BHoMBot check installer |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 7 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the files changed and am happy that the changes match those required from the dependant PR.
I am happy with the changes made specifically to the Environment_Engine as well.
The bot is happy with the installer and versioning, so I'm happy with this being merged into main
.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, documentation-compliance, project-compliance, serialisation, ready-to-merge, null-handling, dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM#1347
Issues addressed by this PR
Test files
Changelog
Additional comments