Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning with Grid and Level migration to Spatial #2732

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1347

Issues addressed by this PR

Test files

Changelog

  • Migrating all methods to do with Grids and Levels in Geometry_Engine to Spatial_Engine
  • Aligning all other Engines to changes made

Additional comments

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

Using the Bot to identify the toolkits affected by this change. I do not expect this check to pass.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • versioning

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • installer

There are 7 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review January 14, 2022 13:11
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the files changed and am happy that the changes match those required from the dependant PR.
I am happy with the changes made specifically to the Environment_Engine as well.
The bot is happy with the installer and versioning, so I'm happy with this being merged into main.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, documentation-compliance, project-compliance, serialisation, ready-to-merge, null-handling, dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@IsakNaslundBh IsakNaslundBh merged commit 62489d8 into main Jan 14, 2022
@IsakNaslundBh IsakNaslundBh deleted the Spatial_oM-#756-MigrateGridsAndLevelsToSpatial branch January 14, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants