-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning with Grid and Level migration to Spatial #398
Aligning with Grid and Level migration to Spatial #398
Conversation
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the files changed and am happy that there is no functionality changed beyond compilation to the changes in the core, and the removal of outdated versioning in place prior to the core versioning system.
Installer and versioning are happy, so I'm happy for this to go into main
.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: code-compliance, copyright-compliance, documentation-compliance, project-compliance, serialisation, ready-to-merge, null-handling, dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
BHoM/BHoM#1347
BHoM/BHoM_Engine#2732
Issues addressed by this PR
Aligning with migration of objects and methods in BHoM and Engine
Test files
Changelog
Additional comments