Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning with Grid and Level migration to Spatial #544

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jan 14, 2022

NOTE: Depends on

BHoM/BHoM#1347
BHoM/BHoM_Engine#2732

Issues addressed by this PR

Aligning with migration of objects and methods in BHoM and Engine

This required adding a dependency on Spatial_oM

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jan 14, 2022
@IsakNaslundBh IsakNaslundBh requested a review from tg359 as a code owner January 14, 2022 10:14
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 14, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 4815601323

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot fix project file ref. 4815601323

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh I am now going to fix the CSProject compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the files changed and am happy that there is no functionality changed beyond compilation to the changes in the core.
Installer and versioning are happy, so I'm happy for this to go into main.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, documentation-compliance, project-compliance, serialisation, ready-to-merge, null-handling, dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 45147f5 into main Jan 14, 2022
@FraserGreenroyd FraserGreenroyd deleted the Spatial_oM-#756-MigrateGridsAndLevelsToSpatial branch January 14, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants