Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1 Deployment #359

Merged
merged 116 commits into from
Mar 28, 2023
Merged

6.1 Deployment #359

merged 116 commits into from
Mar 28, 2023

Conversation

BHoMBot and others added 30 commits January 3, 2023 23:48
I had many students at UCL stuck because they didn't understand this message when they input "Lines" instead of "Bars"
Various fixes at the logic.
Makes it possible to for example specify something for ILoad, and others for say IElementLoad<Bar> and still have both cases covered
…s and fix the grouping, making sure it functions with the push type
@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
@FraserGreenroyd
Copy link
Contributor

While this pull request contains a sufficient review from the toolkit lead @alelom , unfortunately it is blocked by the inability to deploy one or more of the repositories higher up in this repositories dependency chain.

If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.

I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check core

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling
  • check serialisation
  • check core

There are 97 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 6 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306205069

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306213075

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306220551

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306205069

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306213075

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 12306205069 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306220551

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 12306213075 as requested.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 12306220551 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 5 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 28, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit f98b4c4 into main Mar 28, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants