Fix issue with deep dependency types #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GetDependencyTypes
Changing method to compute a dependency depth and use that for sorting the order of the objects
Validated with @alelom that the changes to the create order is only between types that the order is fine to be switched. For example, IMaterialProperty vs Constraint6DOF, and that all dependencies are still pushed before any potential host object. Essentially, there are a couple of orders that all are fine. The previous order was fine, but so is this new one. Hence updating the correct order to new order.
Adding test for the case highlighted in the issue that was the one used to find the problem being fixed in the PR
IsakNaslundBh
added
severity:critical
alelom
approved these changes
Feb 2, 2023
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
|
The check |
|
The check |
IsakNaslundBh
deleted the
BHoM_Adapter-#339-FixIssueWithDeepDependencyTypes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #339
Fixing an issue with the dependency ordering that could occur for some cases where a deeper dependency chain required to be evaluated. Was highlighted when trying to push Bar loads by their own, leading to an error in terms of order where the Bars where pushed before for example Nodes and Sections.
Issue has now been fixed with a tweak to the sorting methodology.
Also, adding a non-generic method for extracting dependency types for a particular type.
Test files
Can be validated with new PushTest in verification solution.
Also, pushing a single BarLoad to Robot, while using BHoM/Robot_Toolkit#506 should work.
Changelog
Additional comments