Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessObjectsForPush() to first Unpack any IContainer, then check for IBHoMObjects #351

Merged

Conversation

alelom
Copy link
Member

@alelom alelom commented Mar 2, 2023

Issues addressed by this PR

Closes #350
Closes #354

ProcessObjectsForPush() now first Unpacks any IContainer, then checks for IBHoMObjects.
This allows to wrap any unpacked non-BHoMObject if required; also, it removes non-relevant warning when an IContainer is provided (as IContainer does not implement IBHoMObject).

Test file

See #350

@alelom alelom requested a review from IsakNaslundBh March 2, 2023 18:17
@alelom alelom self-assigned this Mar 2, 2023
@alelom alelom added the type:bug Error or unexpected behaviour label Mar 2, 2023
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take it as this basically removes a warning for objects of type IContainer that are not inheriting from BHoMObject.

Cannot see how this really would have any bad impact on anything.

Code changes makes sense, and all UTs passing.

Happy to approve!

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 21 requests in the queue ahead of you.

@alelom
Copy link
Member Author

alelom commented Mar 3, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 38 requests in the queue ahead of you.

@alelom alelom changed the title Remove non relevant warning when an IContainer is provided ProcessObjectsForPush first Unpacks any IContainer, then checks for IBHoMObjects Mar 3, 2023
@alelom alelom changed the title ProcessObjectsForPush first Unpacks any IContainer, then checks for IBHoMObjects ProcessObjectsForPush() to first Unpack any IContainer, then check for IBHoMObjects Mar 3, 2023
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 40 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

Please be advised that the check with reference 11744447153 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 249 additional annotations waiting, made up of 249 errors and 0 warnings.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 11 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 16 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 22ec7ae into develop Mar 3, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Adapter-#350-ProcessObjectsUnpackWarning branch March 3, 2023 17:37
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
3 participants