Consumergroup azure names #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 13, 2019 14:55
szoio
requested review from
Azadehkhojandi,
JasonTheDeveloper and
priyakumarank
Azadehkhojandi
approved these changes
Oct 13, 2019
JasonTheDeveloper
approved these changes
Oct 13, 2019
2 tasks
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Ensure generators are generated in alphabetical order * Sort imports in test files * Force consistent ordering on all sorted package import sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds an Azure name field to the consumer groups type in Kubernetes, so that the names of consumer groups in Azure don't need to be globally unique across the cluster.
For example, it should be possible to create a consumer group with the same name, e.g.
test_consumerfor each of the event hubs.Special notes for your reviewer:
refs #236
If applicable:
Covered by existing tests