Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add a name field for event hubs and consumer groups #236

Closed
1 task
szoio opened this issue Sep 24, 2019 · 1 comment
Closed
1 task

Task: Add a name field for event hubs and consumer groups #236

szoio opened this issue Sep 24, 2019 · 1 comment

Comments

@szoio
Copy link
Contributor

szoio commented Sep 24, 2019

Add a name field for event hubs and consumer groups.

As event hub names are scoped by event hub namespace, and consumer group names are scoped by event hubs, there needs to be name field to reflect this, rather than use the kubernetes resource names (that impose uniqueness contraints across the cluster).
For example, it should be possible to create a consumer group with the same name, e.g. test_consumer for each of the event hubs.

**Done criteria **
This is the "done" criteria for this task

  • User can create eventhub resources that are unique for the scope that it is in, rather than cluster-wide scope.

User story reference*

#221

@frodopwns
Copy link
Contributor

this would be more esily fixed by deploying resources you want to have the same name to different namespaces

Porges added a commit that referenced this issue May 11, 2021
* Allow property rewrites to specify match

* Add another type-strip phase

* Update hack/generator/pkg/codegen/pipeline_apply_property_rewrites.go

Co-authored-by: Matthew Christopher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants