cleanup: unused code and pipelines

[alexeldeib]

What this PR does / why we need it:
cleanup duplicate iam code and unused clients, wait more efficiently for cert-manager pods during testing

Special notes for your reviewer:

If applicable:

• this PR contains documentation
• this PR contains tests

[alexeldeib]

this doesn't contain any functional changes -- not sure why it fails CI? same test as the other PR, eventhub consumergroup? "works on my machine" running e2e 🙁

[szoio]

this doesn't contain any functional changes -- not sure why it fails CI? same test as the other PR, eventhub consumergroup? "works on my machine" running e2e 🙁

Hi @alexeldeib - I had the same problem. I think the problem is the eventhub is fails to create in the test suite setup, which causes the consumer group to fail to create. I've fixed this in #348. Btw I really like the approach you took on Incendiary-iguana to abstract out the common controller code.

[alexeldeib]

Thanks @szoio! Looks like I need to rebase both, will see if that does the trick with your changes 🙂

Btw I really like the approach you took on Incendiary-iguana to abstract out the common controller code.

Glad to hear it 😄 Hope we can bring some of the same goodies over here

[frodopwns]

Need to merge the latest code then when the tests pass we are good to go on this one

[alexeldeib]

thanks for rebasing @frodopwns! I'll wait for a final okay but this looks good to merge?

[alexeldeib]

whoops, I confused this with the other PR that had more functional changes -- that still needs a rebase, but this one is cosmetic so I will go ahead and merge 👍