Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema Registry Avro] Move recordings to assets repo #27935

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[Schema Registry Avro] Move recordings to assets repo #27935

merged 1 commit into from
Dec 14, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Dec 14, 2022

Description

Moves test recordings to the azure-sdk-assets repository and creates an assets.json file to enable the new setup, using the generate-assets-json.ps1 script.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative. Schema Registry test-enhancement labels Dec 14, 2022
@mccoyp mccoyp marked this pull request as ready for review December 14, 2022 00:45
swathipil
swathipil approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mccoyp mccoyp merged commit 04e4891 into main Dec 14, 2022
@mccoyp mccoyp deleted the asset-sync-sr-avro branch December 14, 2022 01:29
iscai-msft added a commit that referenced this pull request Dec 15, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
25011db 
…into add_multiapi_combiner

* 'main' of https://github.com/Azure/azure-sdk-for-python: (214 commits)
  [ML] [Pipelines] Make optional input has consistent behavior in @pipeline (#27904)
  [AutoRelease] t2-network-2022-11-29-34202(can only be merged by SDK owner) (#27721)
  add test for early available output not set is_control (#27942)
  [AutoRelease] t2-billingbenefits-2022-12-12-85945(can only be merged by SDK owner) (#27905)
  [ml] support for registry environment next version auto increment (#27920)
  Fix path validation when specifying data asset using latest tag (#27957)
  [Eventhubs] Remove Six (#27948)
  Sync eng/common directory with azure-sdk-tools for PR 4944 (#27952)
  add experimental tag to job definition class (#27949)
  [Monitor][Query] Regen with DPG (#27831)
  [Tables] Move recordings to assets repo (#27927)
  Fixed bug in sip routing. SDK shouldnt send empty patch. (#27919)
  Update prepare-pipelines.yml (#27918)
  [auto relesae] support run recording test (#27940)
  refactor:eventhub/_eventprocessor:type hint added (#26208)
  [Question Answering] Move recordings to assets repo (#27939)
  [Conversations] Move recordings to assets repo (#27938)
  [Release_sdk_status] Fix release_sdk_status for run test break (#27906)
  [Schema Registry Avro] Move recordings to assets repo (#27935)
  [Schema Registry] Move recordings to assets repo (#27934)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil approved these changes

@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan is a code owner

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative. Schema Registry test-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccoyp @swathipil