Fixed bug in sip routing. SDK shouldnt send empty patch. #27919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiriburant
requested review from
miguhern,
whisper6284,
RoyHerrod and
danielav7
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
danielortega-msft
approved these changes
Dec 13, 2022
iscai-msft
added a commit
that referenced
this pull request
Dec 15, 2022
…into add_multiapi_combiner * 'main' of https://github.com/Azure/azure-sdk-for-python: (214 commits) [ML] [Pipelines] Make optional input has consistent behavior in @pipeline (#27904) [AutoRelease] t2-network-2022-11-29-34202(can only be merged by SDK owner) (#27721) add test for early available output not set is_control (#27942) [AutoRelease] t2-billingbenefits-2022-12-12-85945(can only be merged by SDK owner) (#27905) [ml] support for registry environment next version auto increment (#27920) Fix path validation when specifying data asset using latest tag (#27957) [Eventhubs] Remove Six (#27948) Sync eng/common directory with azure-sdk-tools for PR 4944 (#27952) add experimental tag to job definition class (#27949) [Monitor][Query] Regen with DPG (#27831) [Tables] Move recordings to assets repo (#27927) Fixed bug in sip routing. SDK shouldnt send empty patch. (#27919) Update prepare-pipelines.yml (#27918) [auto relesae] support run recording test (#27940) refactor:eventhub/_eventprocessor:type hint added (#26208) [Question Answering] Move recordings to assets repo (#27939) [Conversations] Move recordings to assets repo (#27938) [Release_sdk_status] Fix release_sdk_status for run test break (#27906) [Schema Registry Avro] Move recordings to assets repo (#27935) [Schema Registry] Move recordings to assets repo (#27934) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, we found bug in sending PATCH for sip configuration. When the trunks dictionary on the backend is already empty and user tries to call set_trunks with empty list, the API returns 422, unproccessable entity, because the PATCH request has empty body. This happens, because for trunks dictionary, we're using merge patch.
To fix this, check was added, to send the PATCH only if there are any trunks, that changed.
Scenarios for set_routes don't have this problem, as routes list is always completely replaced and not merge patched.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines