Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor:eventhub/_eventprocessor:type hint added #26208

Merged
merged 4 commits into from
Dec 14, 2022
Merged

refactor:eventhub/_eventprocessor:type hint added #26208

merged 4 commits into from
Dec 14, 2022

Conversation

JJHWAN
Copy link
Contributor

@JJHWAN JJHWAN commented Sep 14, 2022 •
edited
Loading

Description

issue #25471

Changed \eventhub\azure-eventhub\azure\eventhub_eventprocessor directory with type hints

Will work with other dir too, later :)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Event Hubs customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 14, 2022
@ghost
Copy link

ghost commented Sep 14, 2022

Thank you for your contribution JJHWAN! We will review the pull request and get back to you soon.

swathipil
swathipil reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JJHWAN - Thanks for working on updating these type hints! I've left a few comments and can take another look once those have been addressed.

(I think this PR fixes #26209. Is that correct?)

@swathipil swathipil mentioned this pull request Sep 14, 2022
Closed
@JJHWAN
Copy link
Contributor Author

JJHWAN commented Sep 25, 2022

@swathipil applied your reviews!

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hi @JJHWAN. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Hi @JJHWAN. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@swathipil
Copy link
Member

/reopen

@swathipil swathipil reopened this Dec 9, 2022
@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Dec 9, 2022
@swathipil
Copy link
Member

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member

/azp run python - eventhub - tests

1 similar comment
@swathipil
Copy link
Member

/azp run python - eventhub - tests

@swathipil
Copy link
Member

/azp run python - eventhub - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member

/azp run python - eventhub - tests

@swathipil swathipil merged commit 8cb6b38 into Azure:main Dec 14, 2022
iscai-msft added a commit that referenced this pull request Dec 15, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
25011db 
…into add_multiapi_combiner

* 'main' of https://github.com/Azure/azure-sdk-for-python: (214 commits)
  [ML] [Pipelines] Make optional input has consistent behavior in @pipeline (#27904)
  [AutoRelease] t2-network-2022-11-29-34202(can only be merged by SDK owner) (#27721)
  add test for early available output not set is_control (#27942)
  [AutoRelease] t2-billingbenefits-2022-12-12-85945(can only be merged by SDK owner) (#27905)
  [ml] support for registry environment next version auto increment (#27920)
  Fix path validation when specifying data asset using latest tag (#27957)
  [Eventhubs] Remove Six (#27948)
  Sync eng/common directory with azure-sdk-tools for PR 4944 (#27952)
  add experimental tag to job definition class (#27949)
  [Monitor][Query] Regen with DPG (#27831)
  [Tables] Move recordings to assets repo (#27927)
  Fixed bug in sip routing. SDK shouldnt send empty patch. (#27919)
  Update prepare-pipelines.yml (#27918)
  [auto relesae] support run recording test (#27940)
  refactor:eventhub/_eventprocessor:type hint added (#26208)
  [Question Answering] Move recordings to assets repo (#27939)
  [Conversations] Move recordings to assets repo (#27938)
  [Release_sdk_status] Fix release_sdk_status for run test break (#27906)
  [Schema Registry Avro] Move recordings to assets repo (#27935)
  [Schema Registry] Move recordings to assets repo (#27934)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swathipil swathipil swathipil approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan is a code owner

@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence is a code owner

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JJHWAN @swathipil