Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn off strictPeerDep #6021

Closed
wants to merge 1 commit into from
Closed

turn off strictPeerDep #6021

wants to merge 1 commit into from

Conversation

KarishmaGhiya
Copy link
Member

Disablingsince this setting should be used only when the mono-repos doesn't have conflicting peer dependencies. We have conflicting peer dependency on rhea-promise - between versions - 1.0.0 and 0.1.15

cc: @mikeharder @bsiegel @bterlson

@KarishmaGhiya KarishmaGhiya added the EngSys This issue is impacting the engineering system. label Nov 4, 2019
@mikeharder
Copy link
Member

mikeharder commented Nov 4, 2019 •
edited
Loading

I believe strictPeerDependencies cannot be enabled in a repo which requires conflicting peer dependencies. See this comment for a minimal repro and analysis:

microsoft/rushstack#1415 (comment)

If and when our repo no longer requires conflicting peer deps (#5999), this setting could be re-enabled.

@bsiegel
Copy link
Member

bsiegel commented Nov 4, 2019

Would like to hear back from Pete about whether this is accurate before merging, but I suspect you're correct.

@KarishmaGhiya
Copy link
Member Author

Might add this step in PR #6007

@ramya-rao-a ramya-rao-a mentioned this pull request Nov 5, 2019
Merged
@mikeharder
Copy link
Member

Included in #5135

@mikeharder mikeharder closed this Nov 7, 2019
@KarishmaGhiya KarishmaGhiya deleted the disablePeerDep branch November 7, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson bterlson approved these changes

@mikeharder mikeharder mikeharder approved these changes

@bsiegel bsiegel Awaiting requested review from bsiegel

Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KarishmaGhiya @mikeharder @bsiegel @bterlson