Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump package versions #6007

Merged
merged 7 commits into from
Nov 7, 2019
Merged

bump package versions #6007

merged 7 commits into from
Nov 7, 2019

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Nov 2, 2019 •
edited
Loading

Bumping versions of all preview/GA packages that were released this week

@KarishmaGhiya KarishmaGhiya force-pushed the bumpVersions branch 2 times, most recently from 602bf16 to e4d2b7b Compare November 5, 2019 21:02
@KarishmaGhiya KarishmaGhiya added EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels Nov 5, 2019
@KarishmaGhiya KarishmaGhiya mentioned this pull request Nov 5, 2019
Closed
danieljurek
danieljurek approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving current batch of changes as these look OK.

A couple version bumps are missing:

  • app-configuration
  • keyvault-certificates

Some others may be releasing today as well

@ramya-rao-a
Copy link
Contributor

@KarishmaGhiya, Your changes from #6021 and #6018 have bled into this PR. Was that intentional?

@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Nov 5, 2019 •
edited
Loading

@KarishmaGhiya, Your changes from #6021 and #6018 have bled into this PR. Was that intentional?

@ramya-rao-a From #6021 yes, I need that change in this PR for it to work. i haven't used any changes from #6018 .That PR is specifically for updating the versions for rush and pnpm unrelated to any of these changes

@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Nov 6, 2019 •
edited
Loading

@danieljurek Updated versions of the remianing packages that were released this week too - app-configuration, eventhubs, eventhubs-checkpointstore-blob, keyvault-certificates

@KarishmaGhiya KarishmaGhiya force-pushed the bumpVersions branch 2 times, most recently from 2b5b817 to f5febfb Compare November 7, 2019 00:56
@ramya-rao-a
Copy link
Contributor

@KarishmaGhiya After the latest force-push, the current state of the PR is that it has only 2 files in it, neither of them update actual package versions. If the PR is still a work in progress, can you please prefix the title with WIP and then remove it once the PR is ready for review?

@KarishmaGhiya KarishmaGhiya changed the title bump package versions [Draft] bump package versions Nov 7, 2019
@KarishmaGhiya KarishmaGhiya changed the title [Draft] bump package versions bump package versions Nov 7, 2019
danieljurek
danieljurek approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but the trailing newline at the end of package.json files seems to have disappeared. If we still care about that it might make sense to add it back in.

The code code changes in version utils to write the file looks correct, so future executions of versioning scripts won't have this small behavioral quirk.

@mikeharder
Copy link
Member

@KarishmaGhiya: Please do restore the missing newlines. We don't want to be flipping back and forth in PRs.

mikeharder
mikeharder requested changes Nov 7, 2019
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore trailing newline in package.json

@mikeharder
Copy link
Member

Approved pending validaton build results

@KarishmaGhiya KarishmaGhiya merged commit cef4dfe into Azure:master Nov 7, 2019
@KarishmaGhiya KarishmaGhiya deleted the bumpVersions branch February 14, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljurek danieljurek danieljurek approved these changes

@weshaggard weshaggard weshaggard approved these changes

@mikeharder mikeharder mikeharder approved these changes

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@daviwil daviwil Awaiting requested review from daviwil

@sophiajt sophiajt Awaiting requested review from sophiajt

@chradek chradek Awaiting requested review from chradek

@xirzec xirzec Awaiting requested review from xirzec

@sadasant sadasant Awaiting requested review from sadasant

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@jiacfan jiacfan Awaiting requested review from jiacfan

@vinjiang vinjiang Awaiting requested review from vinjiang

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu

@bterlson bterlson Awaiting requested review from bterlson

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KarishmaGhiya @ramya-rao-a @mikeharder @danieljurek @weshaggard