Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rush and pnpm #6018

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Update rush and pnpm #6018

merged 6 commits into from
Nov 7, 2019

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Nov 4, 2019 •
edited
Loading

cc: @Azure/azure-sdk-eng

@KarishmaGhiya KarishmaGhiya added the EngSys This issue is impacting the engineering system. label Nov 4, 2019
@ramya-rao-a ramya-rao-a mentioned this pull request Nov 5, 2019
Merged
@ramya-rao-a ramya-rao-a requested a review from bterlson November 6, 2019 00:27
bterlson
bterlson reviewed Nov 6, 2019
View reviewed changes
Copy link
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm v4 dropped support for Node 8, so I think rush.json's nodeSupportedVersionsRange should change to >=10.0.0. Otherwise LGTM.

bterlson
bterlson reviewed Nov 6, 2019
View reviewed changes
Copy link
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rush.json changes approved.

@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Nov 7, 2019 •
edited
Loading

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=181975&view=results
For validation

@KarishmaGhiya KarishmaGhiya merged commit ed65f23 into Azure:master Nov 7, 2019
@KarishmaGhiya KarishmaGhiya deleted the updateRush branch January 27, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson bterlson left review comments

@mikeharder mikeharder mikeharder approved these changes

Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarishmaGhiya @bterlson @mikeharder