Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-amqp] Consider moving rhea-promise from peerDependencies to dependencies #5999

Closed
mikeharder opened this issue Nov 1, 2019 · 1 comment
Closed

[core-amqp] Consider moving rhea-promise from peerDependencies to dependencies #5999

mikeharder opened this issue Nov 1, 2019 · 1 comment
Assignees
@bterlson
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] January

Comments

@mikeharder
Copy link
Member

In core-amqp, we should consider moving rhea-promise from peerDependencies to dependencies. Peer dependencies are generally problematic in JS (e.g. they cause issues with the Rush toolchain).
@mikeharder mikeharder added the Client This issue points to a problem in the data-plane of the library. label Nov 1, 2019
@mikeharder mikeharder mentioned this issue Nov 4, 2019
Closed
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Dec 30, 2019 •
edited
Loading

As part of the changes in 27d9cb1, rhea-promise is no longer a peer dependency

@ramya-rao-a ramya-rao-a added this to the [2020] January milestone Dec 30, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bterlson bterlson

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] January
Development

No branches or pull requests
3 participants
@bterlson @mikeharder @ramya-rao-a