Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-http] Update TokenCredential.getToken to return AccessToken #3529

Closed
daviwil opened this issue Jun 6, 2019 · 1 comment · Fixed by #3681
Closed

[core-http] Update TokenCredential.getToken to return AccessToken #3529

daviwil opened this issue Jun 6, 2019 · 1 comment · Fixed by #3681
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@daviwil
Copy link
Contributor

daviwil commented Jun 6, 2019

This is an issue to track the work for updating the TokenCredential.getToken API to return an AccessToken instead of a string. This is needed for non-HTTP clients so that more information (like expiresOn) can be returned.

/cc @schaabs @ramya-rao-a @bterlson
@triage-new-issues triage-new-issues bot removed the triage label Jun 6, 2019
This was referenced Jun 6, 2019
Merged
Closed
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jun 7, 2019
@schaabs
Copy link
Member

schaabs commented Jun 7, 2019

@daviwil let's go ahead and make this change. I'm making the same change in .NET now.

@daviwil daviwil mentioned this issue Jun 11, 2019
Merged
daviwil added a commit to daviwil/azure-sdk-for-js that referenced this issue Jun 12, 2019
@daviwil
Refactor Azure.Core and Azure.Identity re: Arch Board feedback
160c69c 
This change draws on work done by schaabs in
Azure/azure-sdk-for-net#6525 to refactor Azure.Core and Azure.Identity
to respond to architecture board feedback.  It also makes a couple of
TypeScript-specific tweaks that were discussed at the time
@azure/identity was introduced.

Fixes Azure#3535.
Fixes Azure#3529.
daviwil added a commit that referenced this issue Jun 12, 2019
@daviwil
[Identity] Refactor Azure.Core and Azure.Identity re: Arch Board feed…
8ebe920 
…back (#3681)

This change draws on work done by schaabs in
Azure/azure-sdk-for-net#6525 to refactor Azure.Core and Azure.Identity
to respond to architecture board feedback.  It also makes a couple of
TypeScript-specific tweaks that were discussed at the time
@azure/identity was introduced.

Fixes #3535.
Fixes #3529.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Identity] Refactor Azure.Core and Azure.Identity re: Arch Board feedback daviwil/azure-sdk-for-js
3 participants
@daviwil @schaabs @ramya-rao-a