[Identity] Refactor Azure.Core and Azure.Identity re: Arch Board feedback #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
commented
Jun 11, 2019
daviwil
changed the title
ramya-rao-a
reviewed
Jun 12, 2019
ramya-rao-a
reviewed
Jun 12, 2019
ramya-rao-a
reviewed
Jun 12, 2019
ramya-rao-a
approved these changes
Jun 12, 2019
schaabs
approved these changes
Jun 12, 2019
This change draws on work done by schaabs in Azure/azure-sdk-for-net#6525 to refactor Azure.Core and Azure.Identity to respond to architecture board feedback. It also makes a couple of TypeScript-specific tweaks that were discussed at the time @azure/identity was introduced. Fixes Azure#3535. Fixes Azure#3529.
daviwil
force-pushed
the
core-http-design-tweaks
branch
from
04e70b2 to
160c69c
Compare
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change draws on work done by @schaabs in Azure/azure-sdk-for-net#6525 to refactor Azure.Core and Azure.Identity to respond to architecture board feedback. It also makes a couple of TypeScript-specific tweaks that were discussed at the time @azure/identity was introduced.
Fixes #3535.
Fixes #3529.