[Identity] Add new @azure/identity library and @azure/core-http abstractions #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldnt alias |
daviwil
force-pushed
the
add-azure-identity
branch
from
7ba4d05 to
9b5acac
Compare
ramya-rao-a
suggested changes
Jun 5, 2019
schaabs
reviewed
Jun 5, 2019
|
Thanks for all the feedback so far! I've addressed everything actionable and have moved this PR out of Draft state so that we can move forward with the final review. Please let me know if you have any other feedback! |
daviwil
force-pushed
the
add-azure-identity
branch
from
f65b602 to
3cb64df
Compare
ramya-rao-a
reviewed
Jun 6, 2019
sdk/core/core-http/lib/policies/bearerTokenAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
bterlson
approved these changes
Jun 6, 2019
31 tasks
daviwil
force-pushed
the
add-azure-identity
branch
from
4f16b25 to
f25edd9
Compare
daviwil
changed the title
ramya-rao-a
reviewed
Jun 6, 2019
ramya-rao-a
reviewed
Jun 6, 2019
ramya-rao-a
reviewed
Jun 6, 2019
ramya-rao-a
reviewed
Jun 6, 2019
ramya-rao-a
reviewed
Jun 6, 2019
ramya-rao-a
approved these changes
Jun 6, 2019
ramya-rao-a
reviewed
Jun 6, 2019
|
Thanks again for all the feedback! I'll rebase this PR and then merge it once CI goes green again 🎉 |
daviwil
force-pushed
the
add-azure-identity
branch
from
e52f7d0 to
2fa959a
Compare
|
Argh, now the |
daviwil
force-pushed
the
add-azure-identity
branch
from
2fa959a to
fb0e570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new @azure/identity library for simplifying client authentication in the new Azure data plane SDK libraries. I might wait to add thorough tests so that folks can go ahead and take a dependency on the
@azure/core-httpabstractions ASAP.Questions for Reviewers
Is it a good idea to aliasstring | string[]toCredentialScopesor does that introduce unnecessary import complexity?Should I run Prettier or some other formatter over this code before merging?Tasks
ClientSecretCredentialagainst Azure to ensure it retrieves an access token successfullyAzureCredential,EnvironmentCredential, andClientSecretCredentialRelated to #2650.