-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request for Microsoft.DBforPostgreSQL to add version preview/2024-03-01-privatepreview #29295
Merged
razvanbadea-msft
merged 56 commits into
Azure:main
from
nasc17:nasc/release-postgresql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
Jul 25, 2024
Merged
Review request for Microsoft.DBforPostgreSQL to add version preview/2024-03-01-privatepreview #29295
razvanbadea-msft
merged 56 commits into
Azure:main
from
nasc17:nasc/release-postgresql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
Administrators.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Administrators.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Backups.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Backups.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Capabilities.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Capabilities.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
CheckNameAvailability.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
CheckNameAvailability.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Configuration.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Configuration.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Databases.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Databases.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
FirewallRules.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
FirewallRules.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
FlexibleServers.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
FlexibleServers.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
LongTermRetentionOperation.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Migrations.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Operations.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Operations.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
PrivateDnsZone.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
PrivateDnsZone.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
PrivateEndpointConnections.json | 2024-03-01-preview(47ad93c) | 2018-06-01(main) |
PrivateEndpointConnections.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
PrivateLinkResources.json | 2024-03-01-preview(47ad93c) | 2018-06-01(main) |
PrivateLinkResources.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
QuotaUsages.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
Replicas.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
Replicas.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
ServerLogs.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
ServerStartStopRestart.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
ServerStartStopRestart.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
ThreatProtection.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
VirtualEndpoints.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
VirtualNetwork.json | 2024-03-01-preview(47ad93c) | 2022-12-01(main) |
VirtualNetwork.json | 2024-03-01-preview(47ad93c) | 2023-12-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 4 Warnings warning [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-flexibleserver-2024-03-01-preview | package-flexibleserver-2024-03-01-preview(47ad93c) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
OperationId should contain the verb: 'getautomigrationfreeslots' in:'GetAutoMigrationFreeSlots_List'. Consider updating the operationId Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Migrations.json#L373 |
||
A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/TuningOptions.json#L133 |
RPC-Get-V1-11 | |
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/TuningOptions.json#L272 |
||
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/TuningOptions.json#L286 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Administrators.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Administrators.json#L38 |
PutRequestResponseSchemeArm |
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Administrators_Create' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Administrators.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Administrators.json#L38 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Administrators.json#L108 |
PatchResponseCodes |
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Configuration.json#L126 |
ProvisioningStateSpecifiedForLROPatch |
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Configuration.json#L164 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Configuration.json#L196 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Configuration.json#L196 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Configuration.json#L196 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Databases.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Databases.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Databases.json#L38 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Databases.json#L108 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FirewallRules.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FirewallRules.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FirewallRules.json#L38 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FirewallRules.json#L108 |
ProvisioningStateSpecifiedForLROPut |
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L38 |
ProvisioningStateSpecifiedForLROPut |
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L38 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L38 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:backupRetentionDays. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:geoRedundantBackup. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:mode. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:customWindow. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:passwordAuth. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:name. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:tier. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L175 |
ProvisioningStateSpecifiedForLROPatch |
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/FlexibleServers.json#L182 |
️❌
Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule | Message |
---|---|
MULTIPLE_DEFAULT_TAGS |
The readme file has more than one default tag. readme: specification/postgresql/resource-manager/readme.md |
The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Jun 1, 2024
…ql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
This was referenced Jun 2, 2024
…into nasc/release-postgresql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
…0301-privatepreview' of https://github.com/nasc17/azure-rest-api-specs into nasc/release-postgresql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
…reSQL-V20240301-privatepreview
…0301-privatepreview' of https://github.com/nasc17/azure-rest-api-specs into nasc/release-postgresql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
…reSQL-V20240301-privatepreview
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…ql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
ambrahma
reviewed
Jul 25, 2024
...esql/resource-manager/Microsoft.DBforPostgreSQL/preview/2024-03-01-preview/Capabilities.json
Show resolved
Hide resolved
ambrahma
approved these changes
Jul 25, 2024
…ql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-Suppression
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Approved-Previously
Changes were reviewed and approved in a previous PR
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
new-api-version
resource-manager
SuppressionReviewRequired
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Changes included in this PR:
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Changes in current PR:
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.