-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request for Microsoft.DBforPostgreSQL to add version stable/2024-08-01 #30433
Review request for Microsoft.DBforPostgreSQL to add version stable/2024-08-01 #30433
Conversation
…ql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
…ql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
…ql-Microsoft.DBforPostgreSQL-V20240301-privatepreview
…ql-Microsoft.DBforPostgreSQL-V20240801
Breaking changes previously reviewed and approved in #29295 |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
The first commit needs to be an exact copy of the previous API version. All new changes should only be added in the subsequent commits. This allows the reviewer to get a clear understanding of the actual changes being introduced. With the way the PR is raised now, it is not possible for the reviewer to tell what the changes are. Please either abandon the PR and raise another one with the recommendation or create a new set of commits on this PR following the recommendation. If you are doing the later option please indicate which commit is the exact copy of the previous version. |
…ql-Microsoft.DBforPostgreSQL-V20240801
@razvanbadea-msft The changes have been made within this PR. Changes Introduced here |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@nasc17 Can you please provide an explanation what all the previous 63 commits are covering/changing? The large number of commits in this PR makes the review process very slow and hard to identify the exact changes. |
@nasc17 Please review the Swagger LintDiff check. |
Closing to restart in new PR: #30737 |
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
Added new GA API version 2024-08-01 This stable version introduces following: - Geo + CMK - Revive Dropped - Storage auto growth - IOPS scaling - New location capability api - Long Term Retention Backup - Server Logs - Migrations - Migration Pre-validation - Read replicas - Switchover (Site swap) - Read replicas - Virtual Endpoints - Private Endpoints - Azure Defender / Threat Protection APIs - PG 16 support - PremiumV2_LRS storage type support - Location capability changes for SSDv2 - Migration Roles - Migration Instance Resource Id to support Private endpoint Migrations - On-demand backupFor convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.