Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request for Microsoft.DBforPostgreSQL to add version stable/2024-08-01 #30433

Conversation

nasc17
Copy link
Member

@nasc17 nasc17 commented Sep 4, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes Added new GA API version 2024-08-01 This stable version introduces following: - Geo + CMK - Revive Dropped - Storage auto growth - IOPS scaling - New location capability api - Long Term Retention Backup - Server Logs - Migrations - Migration Pre-validation - Read replicas - Switchover (Site swap) - Read replicas - Virtual Endpoints - Private Endpoints - Azure Defender / Threat Protection APIs - PG 16 support - PremiumV2_LRS storage type support - Location capability changes for SSDv2 - Migration Roles - Migration Instance Resource Id to support Private endpoint Migrations - On-demand backup

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@mikekistler
Copy link
Member

Breaking changes previously reviewed and approved in #29295

@mikekistler mikekistler added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Sep 16, 2024
@nasc17
Copy link
Member Author

nasc17 commented Sep 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 19, 2024
@razvanbadea-msft
Copy link
Contributor

The first commit needs to be an exact copy of the previous API version. All new changes should only be added in the subsequent commits. This allows the reviewer to get a clear understanding of the actual changes being introduced.

With the way the PR is raised now, it is not possible for the reviewer to tell what the changes are. Please either abandon the PR and raise another one with the recommendation or create a new set of commits on this PR following the recommendation. If you are doing the later option please indicate which commit is the exact copy of the previous version.

@razvanbadea-msft razvanbadea-msft added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 20, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 20, 2024
@nasc17
Copy link
Member Author

nasc17 commented Sep 23, 2024

@razvanbadea-msft The changes have been made within this PR.
Exact copy of previous version can be found at commit c678359

Changes Introduced here

@nasc17
Copy link
Member Author

nasc17 commented Sep 23, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@nasc17 nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 24, 2024
@ms-bogdan-rotaru
Copy link
Contributor

ms-bogdan-rotaru commented Sep 25, 2024

@razvanbadea-msft The changes have been made within this PR. Exact copy of previous version can be found at commit c678359

Changes Introduced here

@nasc17 Can you please provide an explanation what all the previous 63 commits are covering/changing? The large number of commits in this PR makes the review process very slow and hard to identify the exact changes.

@ms-bogdan-rotaru
Copy link
Contributor

@nasc17 Please review the Swagger LintDiff check.

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 25, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2024
@nasc17
Copy link
Member Author

nasc17 commented Sep 25, 2024

Closing to restart in new PR: #30737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChange-Go-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PostgreSQL resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants