Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718

nasc17 · 2024-09-25T00:44:57Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ X] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

Index tuning
Added source types for migration
PG 17 support
UltraSSD_LRS storage type support
System assign identity
Citus on Flex cluster support

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-09-25T00:45:00Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-09-25T00:45:00Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/postgresql/armpostgresql	There is no API change compared with the previous version
Go	sdk/resourcemanager/postgresql/armpostgresqlflexibleservers	https://apiview.dev/Assemblies/Review/af578fe7418c4c5b9155096b33a0d480?revisionId=e98f3e876dad42898b68da915f76adaf
Java	azure-resourcemanager-postgresqlflexibleserver	https://apiview.dev/Assemblies/Review/21a61d731117447dbd7223467d7cfa42?revisionId=ee2c8227da004eb8ade68608b6ad9ab4
.Net	Azure.ResourceManager.PostgreSql	https://apiview.dev/Assemblies/Review/bc6c6840edbc4b2b8d716ff05bcd9ee8?revisionId=ac4a7eb031a843fcb47a46130a34c483
Python	azure-mgmt-postgresqlflexibleservers	https://apiview.dev/Assemblies/Review/2f26588813fb482db3523970145d3eb0?revisionId=9eedc210fe2642abb8ce8d5dc9c9baf0
Swagger	Microsoft.DBforPostgreSQL	https://apiview.dev/Assemblies/Review/71938ae007224d959161caa6cdd98d3d?revisionId=7a5fb2d9128e4fa79d06b766c14f2e6d

…ql-Microsoft.DBforPostgreSQL-V20241101-preview

nasc17 · 2024-10-24T03:25:42Z

/azp run

azure-pipelines · 2024-10-24T03:25:59Z

Azure Pipelines successfully started running 3 pipeline(s).

ramoka178 · 2024-10-24T16:57:14Z

Bumped the comment that got resolved but is not implemented. Could you check that and Also fix the Swagger Avocado error

nasc17 · 2024-10-24T17:45:58Z

Bumped the comment that got resolved but is not implemented. Could you check that and Also fix the Swagger Avocado error

@ramoka178 The swagger avocado error we have been given exceptions for approval in previous request: https://github.com/Azure/azure-rest-api-specs/pull/30737/checks?check_run_id=30717134193

nasc17 · 2024-10-25T04:41:28Z

/azp run

azure-pipelines · 2024-10-25T04:41:45Z

Azure Pipelines successfully started running 3 pipeline(s).

nasc17 · 2024-10-28T15:50:02Z

@tadelesh SDK for go is succeeding now, but tag has not been removed.

Sending reminder

...l/resource-manager/Microsoft.DBforPostgreSQL/preview/2024-11-01-preview/FlexibleServers.json

...esql/resource-manager/Microsoft.DBforPostgreSQL/preview/2024-11-01-preview/Capabilities.json

…024-11-01-preview (#30718) * Create copy in 2024-11-01-preview * replace api version * update read me for 20241101 init * add automigration * add tuning * add ultradisk * add version 17 * v5 to v6 * Add to migration sources * Configuration updates * Citus on flex properties * Add system assigned identity * title update * cspell build fix * Add supported features * ref UserAssignedIdentity directly to ManagedServiceIdentity * Remove UserAssignedIdentity * Add securityprofile, add update cluster prop, add cluster to server list * Go back to v5 in flex server json * Add cluster create example , Update create migration, Add create migration with fqdn example, remove cluster properties * Revert "add automigration" This reverts commit d4230a2. * correct case sensitive example issue * Add singleton endpoint for recommendation, and corrections * remove "includedColumns" from Index tuning * Edit optional recommendation type query filter * revert all files back to v5 common-types * Edit recs examples * Edit index tuning parameters * update readme suppression reasons * PR suggestions

nasc17 added 9 commits September 24, 2024 18:37

Create copy in 2024-11-01-preview

cf5441c

replace api version

09949b1

update read me for 20241101 init

651a75c

add automigration

d4230a2

add tuning

08af084

add ultradisk

e761aab

add version 17

470fe72

v5 to v6

e8d208e

Add to migration sources

a596923

nasc17 requested a review from ambrahma September 25, 2024 00:44

microsoft-github-policy-service bot added the PostgreSQL label Sep 25, 2024

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Sep 25, 2024

nasc17 added 5 commits October 4, 2024 17:53

Merge remote-tracking branch 'origin/main' into nasc/release-postgres…

049bd16

…ql-Microsoft.DBforPostgreSQL-V20241101-preview

Configuration updates

b4595f5

Citus on flex properties

878c0a1

Add system assigned identity

f88a27a

title update

53d0e00

nasc17 marked this pull request as ready for review October 5, 2024 03:19

nasc17 requested a review from a team as a code owner October 5, 2024 03:19

cspell build fix

0abdac8

AzureRestAPISpecReview added ARMReview new-api-version NotReadyForARMReview labels Oct 5, 2024

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024

ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024

nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024

ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024

nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 25, 2024

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 25, 2024

ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 25, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 25, 2024

nasc17 requested a review from tadelesh October 28, 2024 15:50

tadelesh removed the BreakingChange-Go-Sdk label Oct 28, 2024

TimLovellSmith added the Approved-Suppression label Oct 28, 2024

nasc17 requested a review from ambrahma October 28, 2024 20:30

ambrahma approved these changes Oct 29, 2024

View reviewed changes

...l/resource-manager/Microsoft.DBforPostgreSQL/preview/2024-11-01-preview/FlexibleServers.json Outdated Show resolved Hide resolved

...esql/resource-manager/Microsoft.DBforPostgreSQL/preview/2024-11-01-preview/Capabilities.json Outdated Show resolved Hide resolved

PR suggestions

504347b

azure-sdk added the BreakingChange-Go-Sdk label Oct 29, 2024

nasc17 removed the BreakingChange-Go-Sdk label Oct 29, 2024

nasc17 merged commit 755a24c into Azure:main Oct 29, 2024
28 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718

Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718

nasc17 commented Sep 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 25, 2024 •

edited

Loading

nasc17 commented Oct 24, 2024

azure-pipelines bot commented Oct 24, 2024

ramoka178 commented Oct 24, 2024 •

edited

Loading

nasc17 commented Oct 24, 2024

nasc17 commented Oct 25, 2024

azure-pipelines bot commented Oct 25, 2024

nasc17 commented Oct 28, 2024

Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718

Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718

Conversation

nasc17 commented Sep 25, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Sep 25, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Sep 25, 2024 • edited Loading

Generated ApiView

nasc17 commented Oct 24, 2024

azure-pipelines bot commented Oct 24, 2024

ramoka178 commented Oct 24, 2024 • edited Loading

nasc17 commented Oct 24, 2024

nasc17 commented Oct 25, 2024

azure-pipelines bot commented Oct 25, 2024

nasc17 commented Oct 28, 2024

nasc17 commented Sep 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 25, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 25, 2024 •

edited

Loading

ramoka178 commented Oct 24, 2024 •

edited

Loading