-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #286: Port read-my-writes fix from V4 #287
Conversation
… caused the status code to be set incorrectly
… and added DocumentClientExceptionTest.statusCodeIsCorrect The latter resulted in moving DocuemntClientExceptionTest from commons to direct-impl. Without the move commons would need to take a dependency on direct-impl which seems undesirable.
…ns and direct-impl
…into danoble/issue-263/retry-not-happening
…e state of a request when it times out
…into issue/#286/port-from-v4
No pipelines are associated with this pull request. |
benchmark/src/main/java/com/microsoft/azure/cosmosdb/benchmark/Main.java
Outdated
Show resolved
Hide resolved
benchmark/src/main/java/com/microsoft/azure/cosmosdb/benchmark/ReadMyWriteWorkflow.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Emulator Example tests CI passed here: https://dev.azure.com/azure-cosmos-java/azure-cosmos-java-private/_build/results?buildId=10264 |
Session Singleregion https CI passed here: https://dev.azure.com/azure-cosmos-java/azure-cosmos-java-private/_build/results?buildId=10265 |
Strong-singleregion-https-tests CI passed here: https://dev.azure.com/azure-cosmos-java/azure-cosmos-java-private/_build/results?buildId=10397 |
Merging the PR now as all the CI has passed. |
See Azure/azure-sdk-for-java#6201.
From a v2.6.X perspective this PR picks up a number of diagnostic improvements that have been introduced to the Direct TCP stack. This PR also bumps the version number to 2.6.4-SNAPSHOT pending release from master.