Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #286: Port read-my-writes fix from V4 #287

Merged
merged 34 commits into from
Dec 2, 2019

Conversation

David-Noble-at-work
Copy link

@David-Noble-at-work David-Noble-at-work commented Nov 8, 2019

See Azure/azure-sdk-for-java#6201.

From a v2.6.X perspective this PR picks up a number of diagnostic improvements that have been introduced to the Direct TCP stack. This PR also bumps the version number to 2.6.4-SNAPSHOT pending release from master.

… caused the status code to be set incorrectly
… and added DocumentClientExceptionTest.statusCodeIsCorrect

The latter resulted in moving DocuemntClientExceptionTest from commons to direct-impl. Without the move commons would need to take a dependency on direct-impl which seems undesirable.
@David-Noble-at-work David-Noble-at-work changed the title Issue #286: Port read-my-writes fix from V4 DRAFT: Issue #286: Port read-my-writes fix from V4 Nov 8, 2019
@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@David-Noble-at-work David-Noble-at-work marked this pull request as ready for review November 9, 2019 17:43
@David-Noble-at-work David-Noble-at-work self-assigned this Nov 9, 2019
@David-Noble-at-work David-Noble-at-work changed the title DRAFT: Issue #286: Port read-my-writes fix from V4 Issue #286: Port read-my-writes fix from V4 Nov 9, 2019
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kushagraThapar
Copy link
Member

@kushagraThapar
Copy link
Member

@kushagraThapar
Copy link
Member

Strong-singleregion-https-tests CI passed here: https://dev.azure.com/azure-cosmos-java/azure-cosmos-java-private/_build/results?buildId=10397

@kushagraThapar
Copy link
Member

Merging the PR now as all the CI has passed.

@kushagraThapar kushagraThapar merged commit 0fa7872 into master Dec 2, 2019
@kushagraThapar kushagraThapar deleted the issue/#286/port-from-v4 branch December 2, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants